Add command cluster delete - #8
Closed
zymap wants to merge 5 commits into
Closed
Conversation
wolfstudy
reviewed
Aug 27, 2019
sijie
requested changes
Aug 28, 2019
| desc := pulsar.LongDescription{} | ||
| desc.CommandUsedFor = "This command is used for getting the cluster data of the specified cluster." | ||
| desc.CommandPermission = "This command requires super-user permissions." | ||
| desc.CommandPermission = "All users can use." |
Member
There was a problem hiding this comment.
two problems here:
-
whenever you are changing the logic, please write the change in the description of the pull request. otherwise no one knows why you are making this change.
-
this command requires super user permissions: https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java#L118
sijie
pushed a commit
that referenced
this pull request
Aug 29, 2019
Master issue: #2 closes #8 Output: ``` ➜ pulsarctl git:(clusters_delete) ./pulsarctl clusters delete -h USED FOR: This command is used for deleting an existing cluster. REQUIRED PERMISSION: This command requires super-user permissions. EXAMPLES: #deleting the cluster named <cluster-name> pulsarctl clusters delete <cluster-name> OUTPUT: #normal output Cluster <cluster-name> delete successfully. #output of doesn't specified a cluster name only one argument is allowed to be used as a name #output of cluster doesn't exist [✖] code: 404 reason: Cluster does not exist Usage: pulsarctl clusters delete [flags] Aliases: delete, delete Common flags: -s, --admin-service-url string The admin web service url that pulsarctl connects to. (default "http://localhost:8080") -C, --color string toggle colorized logs (true,false,fabulous) (default "true") -h, --help help for this command -v, --verbose int set log level, use 0 to silence, 4 for debugging (default 3) Use 'pulsarctl clusters delete [command] --help' for more information about a command. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master issue: #2
Output: